[Fix] Get epsID form config when resource parameter get empty #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiChangkuo
reviewed
Feb 9, 2021
| @@ -94,12 +94,9 @@ func resourceCdmClusterV1() *schema.Resource { | |||
| }, | |||
|
|
|||
| "enterprise_project_id": { | |||
| Type: schema.TypeList, | |||
| Type: schema.TypeString, | |||
There was a problem hiding this comment.
if we want to change the type, we should update the website docs.
| } | ||
| return v2, nil | ||
| sysTags := make([]interface{}, 1, 1) | ||
| tag := map[string]string{ |
There was a problem hiding this comment.
we can directly assign to sysTags[0]
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In general, resources will search provider config when terraform config is empty.
But some resources just only use default value to create resource. It makes user's configuration in the provider useless.
So, we should update this logic referring to subnet or other resources.
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Release note:
PR Checklist
Acceptance Steps Performed