New acc test and update Identity agency support duration param and doc #946

Lance52259 · 2021-02-26T03:35:17Z

What this PR does / why we need it:

Identity agency supports duration setting and updating, valid value is 'ONEDAY', 'FOREVER' and null (null will set duration with 'FOREVER'). In provider, make "FOREVER" become default value (Only use 'ONEDAY' and 'FOREVER' ), because of 'null' equal with 'FOREVER' and null cannot be set into terraform state.
- Only agency createOpts and updateOpts need contains duration parameter, the resource can set and update in create and update function.
Identity agency supports the assignment of delegates to designated users and HUAWEI CLOUD service.
Identity agency missing acc test.
Identity agency document description is Incompleted.
- missing cloud service delegated example .
- missing import example.
- missing whiteline at the end of the document.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. Duration can updating with three value, contains 'ONEDAY' and 'FOREVER'.
2. Split the delegation method into domain_name and service_name. 
  a. Add regex match to check which delegate_service_name or delegate_domain_name input.
  b. Add delegate_service_name description and update delegate_domain_name description.
3. New Identity agency acc test.
4. update document such as txt description and example.

PR Checklist

Tests added/passed.
Documentation updated.
Schema updated.

Acceptance Steps Performed

Delegate another HUAWEI CLOUD account to perform operations on your resources.

make testacc TEST='./huaweicloud' TESTARGS='-run=TestAccIdentityAgency_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run=TestAccIdentityAgency_basic -timeout 360m -parallel 4
=== RUN   TestAccIdentityAgency_basic
=== PAUSE TestAccIdentityAgency_basic
=== CONT  TestAccIdentityAgency_basic
--- PASS: TestAccIdentityAgency_basic (98.09s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       98.133s

Delegate a cloud service to access your resources in other cloud services.

make testacc TEST='./huaweicloud' TESTARGS='-run=TestAccIdentityAgency_service'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run=TestAccIdentityAgency_service -timeout 360m -parallel 4
=== RUN   TestAccIdentityAgency_service
=== PAUSE TestAccIdentityAgency_service
=== CONT  TestAccIdentityAgency_service
--- PASS: TestAccIdentityAgency_service (102.56s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       102.610s

ShiChangkuo · 2021-02-27T02:34:07Z

huaweicloud/resource_huaweicloud_identity_agency_test.go

+				Config: testAccIdentityAgency_basic(rName),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckIdentityAgencyExists(resourceName, &agency),
+					resource.TestCheckResourceAttr(resourceName, "name", rName),


suggest to add more attr check

now we have five attribute check in acc test.

ShiChangkuo · 2021-02-27T02:45:27Z

docs/resources/identity_agency.md

@@ -27,6 +28,25 @@ resource "huaweicloud_identity_agency" "agency" {
 }
 ```

+### Delegate the operation authority of the resources in the account to Huaweicloud service


Delegate a cloud service to access your resources in other cloud services.

thanks for suggestion, it's updated at document.

ShiChangkuo · 2021-02-27T02:46:15Z

docs/resources/identity_agency.md

@@ -9,6 +9,7 @@ This is an alternative to `huaweicloud_iam_agency_v3`

 ## Example Usage

+### Delegate the operation authority of the resources in the account to other Huaweicloud accounts


Delegate another HUAWEI CLOUD account to perform operations on your resources.

thanks for suggestion, it's updated at document.

ShiChangkuo · 2021-02-27T02:47:43Z

docs/resources/identity_agency.md

@@ -38,6 +58,11 @@ The following arguments are supported:
    agency. The value is a string of 0 to 255 characters.

 * `delegated_domain_name` - (Required, String) The name of delegated domain.


can we add a new parameter named delegated_service_name ?

new parameter delegated_service_name and update param create, update and read operation in identity agency. please help reviewing code.

ShiChangkuo · 2021-02-27T08:04:41Z

huaweicloud/resource_huaweicloud_identity_agency.go

@@ -437,10 +459,15 @@ func resourceIAMAgencyV3Update(d *schema.ResourceData, meta interface{}) error {

 	agencyID := d.Id()

-	if d.HasChanges("delegated_domain_name", "description") {
+	if d.HasChanges("delegated_domain_name", "description", "duration") {


should put "delegated_service_name" in the list

thanks, 'delegated_service_name' is putting into the list

ShiChangkuo · 2021-02-27T08:05:36Z

huaweicloud/resource_huaweicloud_identity_agency.go

 	d.Set("description", a.Description)
 	d.Set("duration", a.Duration)
 	d.Set("expire_time", a.ExpireTime)
 	d.Set("create_time", a.CreateTime)

+	if ok, err := regexp.MatchString("^op_svc_[A-Za-z]+$", a.DelegatedDomainName); err != nil {
+		fmt.Printf("regexp error, err= %s", err)


did you mean log.Printf ?

It's updated using fmt.Errorf return.

thanks, there need log.Printf actually.

Lance52259 changed the title ~~Identity agency patch~~ New acc test and update Identity agency support duration param and doc Feb 26, 2021

ShiChangkuo reviewed Feb 27, 2021

View reviewed changes

feat: agency supports duration and new acc test

60b4249

ShiChangkuo reviewed Feb 27, 2021

View reviewed changes

Lance52259 and others added 3 commits February 27, 2021 16:57

refactor: Split the delegation method into domain_name and service_name

54d1289

docs: Adjust the structure of document and add missing content

12bc701

Merge branch 'master' into IdentityAgencyPatch

5d78380

ShiChangkuo merged commit 321f297 into huaweicloud:master Feb 27, 2021

Lance52259 deleted the IdentityAgencyPatch branch March 1, 2021 01:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New acc test and update Identity agency support duration param and doc #946

New acc test and update Identity agency support duration param and doc #946

Lance52259 commented Feb 26, 2021 •

edited

Loading

ShiChangkuo Feb 27, 2021

Lance52259 Feb 27, 2021

ShiChangkuo Feb 27, 2021

Lance52259 Feb 27, 2021

ShiChangkuo Feb 27, 2021

Lance52259 Feb 27, 2021

ShiChangkuo Feb 27, 2021

Lance52259 Feb 27, 2021 •

edited

Loading

ShiChangkuo Feb 27, 2021

Lance52259 Feb 27, 2021

ShiChangkuo Feb 27, 2021

Lance52259 Feb 27, 2021 •

edited

Loading

Lance52259 Feb 27, 2021

		@@ -9,6 +9,7 @@ This is an alternative to `huaweicloud_iam_agency_v3`

		## Example Usage

		### Delegate the operation authority of the resources in the account to other Huaweicloud accounts

		@@ -38,6 +58,11 @@ The following arguments are supported:
		agency. The value is a string of 0 to 255 characters.

		* `delegated_domain_name` - (Required, String) The name of delegated domain.

New acc test and update Identity agency support duration param and doc #946

New acc test and update Identity agency support duration param and doc #946

Conversation

Lance52259 commented Feb 26, 2021 • edited Loading

PR Checklist

Acceptance Steps Performed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Lance52259 Feb 27, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Lance52259 Feb 27, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Lance52259 commented Feb 26, 2021 •

edited

Loading

Lance52259 Feb 27, 2021 •

edited

Loading

Lance52259 Feb 27, 2021 •

edited

Loading