-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHPullRequest isn't reactable #1749
Comments
@jmadureira make sure you have the required permissions, github api also returns 404s in case you don't have the required permissions |
Hi @Haarolean. I ended up enabling all permissions just in case and still got the same error. The URL the client is trying to access is not listed anywhere in the Github documentation (at least I'm not able to find it). |
Pull requests are sorta issues and for reactions, you need to use the issues API to react. Fixes hub4j#1749
You're totally right, there's a bug here. Pull requests should use the issues endpoint to create reactions (as pull requests are indeed issues with additional stuff). I created #1808 to fix it. |
Describe the bug
Trying to call
Reactable.createAction(...)
on aGHPullRequest
throws aNot Found
error.To Reproduce
Steps to reproduce the behavior:
GHPullRequest
instancecreateAction
on that instanceExpected behavior
Not really certain. The URL the the client is trying to access:
https://api.github.com/repos/OWNER/REPO/pulls/PR_NUMBER/reactions
doesn't really exist so either:GHPullRequest
shouldn't be marked asReactable
or;GHPullRequest
should be calling thehttps://api.github.com/repos/OWNER/REPO/issues/ISSUE_NUMBER/reactions
instead assuming it yields desired resultDesktop (please complete the following information):
Additional context
The text was updated successfully, but these errors were encountered: