Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packages, actions and dependabot to meta #1167

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

shuheiktgw
Copy link
Contributor

Description

I've added packages, actions, and dependabot to GHMeta class. Thank you for your review! 👍

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than main. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

When creating a PR:

  • Fill in the "Description" above.
  • Enable "Allow edits from maintainers".

@bitwiseman
Copy link
Member

Could you provide a link to the doc page describing these?

@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #1167 (0bb18ee) into main (1a77dd2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1167      +/-   ##
============================================
+ Coverage     73.55%   73.57%   +0.01%     
- Complexity     1831     1834       +3     
============================================
  Files           185      185              
  Lines          6127     6130       +3     
  Branches        365      365              
============================================
+ Hits           4507     4510       +3     
  Misses         1400     1400              
  Partials        220      220              
Impacted Files Coverage Δ
src/main/java/org/kohsuke/github/GHMeta.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a77dd2...0bb18ee. Read the comment docs.

Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

There's no need to change the example classes. Having the extra fields doesn't improve the clarity of the example. Please revert that part of the change.

@shuheiktgw
Copy link
Contributor Author

@bitwiseman

Could you provide a link to the doc page describing these?

Sure, here is the doc page!

https://docs.github.com/en/rest/reference/meta#get-github-meta-information

There's no need to change the example classes.

OK, I reverted the change related to the example class. Sorry for force-pushing 🙇 (It was much easier simply reset changes on the file)

@bitwiseman bitwiseman merged commit 4abf33a into hub4j:main Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants