Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link to GitHub conditional requests doc #1601

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

jjlharrison
Copy link
Contributor

@jjlharrison jjlharrison commented Jan 19, 2023

Description

The link to the conditional request document is outdated, this updates to a working one.

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments as appropriate. Consider including links in comments to relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 79.31% // Head: 79.31% // No change to project coverage 👍

Coverage data is based on head (61c1e43) compared to base (472adbb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1601   +/-   ##
=========================================
  Coverage     79.31%   79.31%           
  Complexity     2140     2140           
=========================================
  Files           206      206           
  Lines          6565     6565           
  Branches        362      362           
=========================================
  Hits           5207     5207           
  Misses         1146     1146           
  Partials        212      212           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bitwiseman bitwiseman merged commit 05c92fd into hub4j:main Jan 25, 2023
@jjlharrison jjlharrison deleted the patch-1 branch January 25, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants