Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #1603

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Spelling #1603

merged 2 commits into from
Jan 25, 2023

Conversation

bitwiseman
Copy link
Member

@bitwiseman bitwiseman commented Jan 25, 2023

Description

Replaces #1600

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments as appropriate. Consider including links in comments to relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 79.31% // Head: 79.22% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (b89f35f) compared to base (472adbb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1603      +/-   ##
============================================
- Coverage     79.31%   79.22%   -0.09%     
- Complexity     2140     2141       +1     
============================================
  Files           206      206              
  Lines          6565     6576      +11     
  Branches        362      364       +2     
============================================
+ Hits           5207     5210       +3     
- Misses         1146     1154       +8     
  Partials        212      212              
Impacted Files Coverage Δ
src/main/java/org/kohsuke/github/GHCommit.java 87.03% <ø> (ø)
src/main/java/org/kohsuke/github/GHCompare.java 92.30% <ø> (ø)
...va/org/kohsuke/github/GHFileNotFoundException.java 70.00% <ø> (ø)
...rc/main/java/org/kohsuke/github/GHIOException.java 88.88% <ø> (ø)
src/main/java/org/kohsuke/github/GHIssue.java 74.05% <ø> (ø)
src/main/java/org/kohsuke/github/GHMyself.java 39.21% <ø> (ø)
...c/main/java/org/kohsuke/github/GHOrganization.java 68.21% <ø> (ø)
src/main/java/org/kohsuke/github/GHRateLimit.java 88.05% <ø> (ø)
src/main/java/org/kohsuke/github/GHRef.java 97.43% <ø> (ø)
src/main/java/org/kohsuke/github/GHRepository.java 69.11% <ø> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bitwiseman bitwiseman merged commit 5a4d20d into hub4j:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants