Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the public events for user API #1642

Merged
merged 3 commits into from
Apr 22, 2023

Conversation

PierreBtz
Copy link
Contributor

Description

This change adds support for https://docs.github.com/en/rest/activity/events?apiVersion=2022-11-28#list-public-events-for-a-user

Note: local run of mvn -D enable-ci clean install site fails on a totally untouched test, I made sure I didn't accidentally modify the stubs for this test but I'm out of ideas (ran with java 11, 17 is failing but I bet you are already aware :)).

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments as appropriate. Consider including links in comments to relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (afe6732) 79.86% compared to head (0fa0274) 79.89%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1642      +/-   ##
============================================
+ Coverage     79.86%   79.89%   +0.03%     
- Complexity     2191     2197       +6     
============================================
  Files           208      209       +1     
  Lines          6659     6670      +11     
  Branches        364      364              
============================================
+ Hits           5318     5329      +11     
  Misses         1127     1127              
  Partials        214      214              
Impacted Files Coverage Δ
src/main/java/org/kohsuke/github/GitHub.java 82.51% <100.00%> (+0.23%) ⬆️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bitwiseman bitwiseman merged commit b4ac83a into hub4j:main Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants