Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new enums for verification reasons using X.509 certificate sig… #1715

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

AstroTlaloc
Copy link
Contributor

@AstroTlaloc AstroTlaloc commented Sep 20, 2023

Description

Fixes: #1714

GHVerification$Reason needs to be updated with new unverified values for signatures using X.509 certificates as signing key. Github documentation: https://docs.github.com/en/graphql/reference/enums#gitsignaturestate

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
  • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
  • Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
...c/main/java/org/kohsuke/github/GHVerification.java 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@AstroTlaloc
Copy link
Contributor Author

@bitwiseman can you help me out reviewing this PR?

@bitwiseman bitwiseman merged commit 363318b into hub4j:main Oct 19, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

org.kohsuke.github.GHVerification$Reason deserialization failure
2 participants