Remove PyCrypto dependencies #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ddress linter issues
vladmonea
force-pushed
the
pycrypto-replace-lib
branch
from
cd4fe64
to
5a3e28f
Compare
grogsaxle
approved these changes
Sep 12, 2022
| # How often in seconds 3600 = 1 hour to set log level to log.error/critical | ||
| # maybe set in /etc/hubble/hubble | ||
| verif_log_dampener_lim = 3600 | ||
| VERIFY_LOG_DAMPENER_LIM = [3600] |
There was a problem hiding this comment.
@vladmonea Why the change to an array here?
There was a problem hiding this comment.
the only way i found to lose the global usage and have the value available in functions' inner scopes. i don't like it, myself, it can be changed, if needed.
mzainea
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyCrypto is out-dated and unmaintained, so we're removing it from the code.
This PR also takes care of some code style and linter issues. Furthermore, some refactoring is made to make functions and variables more palatable.