Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

same nonce value from etherjs provider #304

Closed
katat opened this issue Jul 24, 2018 · 0 comments · Fixed by #309
Closed

same nonce value from etherjs provider #304

katat opened this issue Jul 24, 2018 · 0 comments · Fixed by #309
Assignees
Labels
critical something very important to take care of
Milestone

Comments

@katat
Copy link
Contributor

katat commented Jul 24, 2018

For the payment in ledger nano, it needs provide nonce value to sign with the transaction. Currently the nonce value is getting from the etherjs provider.getTransactionCount(), which could return the same value due to the delay of the transaction confirmation in the network.

When sending the transactions with the same nonce to the network, it throws known transaction error from the etherjs for the last transaction broadcast attempt.

Have to figure out a way to avoid the same nonce issue.

May be helpful to take a look at the code in etherjs to see how it handles this issue for its sendTransaction function.

@katat katat added the critical something very important to take care of label Jul 24, 2018
@katat katat added this to the 0.3.0 milestone Jul 24, 2018
@katat katat self-assigned this Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical something very important to take care of
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant