Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unhandled network exception #660

Closed
liamaharon opened this issue Dec 18, 2018 · 3 comments
Closed

Unhandled network exception #660

liamaharon opened this issue Dec 18, 2018 · 3 comments
Assignees
@liamaharon
Labels
bug Something isn't working medium
Milestone
0.8.0

Comments

@liamaharon
Copy link
Contributor

liamaharon commented Dec 18, 2018 •
edited
Loading

Sometimes an unhandled network error will cause a system popup dialog.

screenshot 2018-12-18 at 12 08 52

Seems to be most reproducible when waking a system from sleep(?)
@liamaharon liamaharon added bug Something isn't working medium labels Dec 18, 2018
@liamaharon liamaharon self-assigned this Dec 18, 2018
@liamaharon
Copy link
Contributor Author

dev stacktrace:

Unhandled Promise Rejection
Error: Request has been terminated
Possible causes: the network is offline, Origin is not allowed by Access-Control-Allow-Origin, the page is being unloaded, etc.
    at Request.crossDomainError (webpack-internal:///./node_modules/superagent/lib/client.js:621:13)
    at XMLHttpRequest.xhr.onreadystatechange (webpack-internal:///./node_modules/superagent/lib/client.js:703:19)

@liamaharon
Copy link
Contributor Author

Appears to be an issue in the SDK. Will open a PR to ignore this particular exception until it's fixed upstream.
hubiinetwork/nahmii-sdk#67

@liamaharon liamaharon added this to the 0.8.0 milestone Dec 20, 2018
@liamaharon liamaharon mentioned this issue Dec 20, 2018
Merged
@liamaharon
Copy link
Contributor Author

PR opened for a proper solution upstream, we can remove the band-aid fix once it's merged and we've updated our dependencies hubiinetwork/nahmii-sdk#75

@liamaharon liamaharon reopened this Jan 16, 2019
@katat katat closed this as completed Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liamaharon liamaharon

Labels
bug Something isn't working medium
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
2 participants
@katat @liamaharon