Fixes missing status on column breadcrumbs #204
Conversation
| return this.get("issue.data.current_state.name") === this.get("column.data.name"); | ||
| }.property("issue.data.current_state.name", "column.data.name", "issue.data.state"), | ||
| return this.get("issue.columnIndex") === this.get("column.data.index"); | ||
| }.property("issue.columnIndex", "column.data.index"), |
There was a problem hiding this comment.
Is this based on 'real' index or 'user input' index
'real' index == position in the array of columns
user input index == X - Column name from label
There was a problem hiding this comment.
That would be 'user input' index
There was a problem hiding this comment.
But I can see where you are going with that, I am going to reimplement using real array index.
… isSelected based on whether the issue is present in the column
…hes isSelected when sortedIssues changes
| return this.get("column.sortedIssues").find((issue)=> { | ||
| return issue.get("id") === current_issue.get("id"); | ||
| }); | ||
| }.property("column.sortedIssues.@each"), |
There was a problem hiding this comment.
How does this affect the render time on the milestones view?
There was a problem hiding this comment.
I double checked the rendering speed with the Ember inspector, they are virtually identical.
I am interested when I make the sister change with the milestone column model if we see any change. But that is a seperate PR.
|
This change looks good to me. |
|
|
…dcrumbs Fixes missing status on column breadcrumbs
|
Any reason this hasn't been deployed yet? |
|
Nope, just deployed! |
Addresses #187
Column crumb statuses were computing based on their names, however this breaks down on WIP columns when a linked repo does not share the same WIP. Fixes by moving a columns sortedIssues into the column itself, enabling us to check if the issue itself exists in the column or not.