Differentiate new PRs from issues in notifications

[dahlbyk]

Follow-up from #255

Fixes this:

[dahlbyk]

This isn't working: mash.payload.pull_request.nil?. I have once again conflated event and web hook payloads.

Rather than infer PR-ness from payload.issue properties (head, base, commits_url), it seems reasonable to explicitly mark PR payloads as such: 77b26c3.

[dahlbyk]

Third time's a charm:

Ready for review.

[discorick]

this could also be written params[:issue].key?(:pull_request) if the webhook payload is similar enough to the original issue payload that is.

[dahlbyk]

I'm adding :pull_request to the base payload, not attaching it to the :issue hash.

[discorick]

Oh, I assume in discovery you found that the webhook doesn't carry a PR object ?

[dahlbyk]

Correct, in WebhooksController#publish_pull_request_event we essentially "rename" the pull_request part of the payload as issue. So I added a simple flag in 77b26c3 to identify PRs again:

        message = HashWithIndifferentAccess.new(
+        :pull_request => true,
         :issue => payload[:pull_request],
         ...

This change just passed that value on through.

[discorick]

Looks good to me ing it