Pagerduty ack assigned

[technicalpickles]

github/hubot-scripts#1280 ported to this repo cc @ChrisLundquist

[ChrisLundquist]

👍

[technicalpickles]

Feeling pretty good about this. I added the idea of acking only your assigned things to resolving as well.

One thing I was considering still was like /pager ack! and /pager resolve! for doing everything, not just your assigned. Thoughts?

[ChrisLundquist]

Yeah, having resolve/ack behave the same, along with the ! notation, works for me. I like it.

[jnewland]

One thing I was considering still was like /pager ack! and /pager resolve! for doing everything, not just your assigned. Thoughts?

👍

[technicalpickles]

Mentioned this on another issue, but since pagerduty supports multiple people being assigned to an incident, we need to check for that. Basically, there used to be incident.assigned_to_user, but it's been deprecated in favor of incident.assigned_to, which is an array of objects.

[technicalpickles]

Basically, there used to be incident.assigned_to_user, but it's been deprecated in favor of incident.assigned_to, which is an array of objects.

Fixed this in 365e306

[technicalpickles]

One thing I was considering still was like /pager ack! and /pager resolve! for doing everything, not just your assigned.

Implemented because of the 👍 ✨

Feeling pretty good about this. Only question is what version I should bump to this. Looking at http://semver.org/, it's about backwards compatability, which this would qualify for. However, the semantic use of it is a bit different, which could catch people off guard. Since this is pretty new, I'd be okay with bumping minor version.

[jnewland]

Since this is pretty new, I'd be okay with bumping minor version.

Seems fine.