Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow smart quotes in who's on call command #45

Merged
merged 1 commit into from
Sep 1, 2015
Merged

Allow smart quotes in who's on call command #45

merged 1 commit into from
Sep 1, 2015

Conversation

kashizui
Copy link

@kashizui kashizui commented Sep 1, 2015

Mac users (on the Hubot-Slack integration at least) often have trouble with the "who's on call" command, since the default OS X settings will convert quotation marks into angled quotation marks: “” and ‘’ .

This change simply recognizes the angled single quote that automatically gets rendered when Mac users type out the command:

hubot who’s on call

@alexlo03
Copy link

alexlo03 commented Sep 1, 2015

👍

@stephenyeargin
Copy link
Member

There is setting to disable this in most Mac applications by clicking in the text field and going to Substitutions > Smart Quotes, but I'd agree that is super annoying. 👍

screen shot 2015-09-01 at 5 53 25 pm

stephenyeargin added a commit that referenced this pull request Sep 1, 2015
Allow smart quotes in who's on call command
@stephenyeargin stephenyeargin merged commit 3b930bf into hubot-archive:master Sep 1, 2015
@kashizui
Copy link
Author

kashizui commented Sep 1, 2015

Yep, the main problem is people learning to use the command for the first
time, or those who are just unwilling to turn off the setting.

They can always choose to use hubot who is on call, but that isn't
currently the default syntax listed in the help docs.
On Tue, Sep 1, 2015 at 6:54 PM Stephen Yeargin notifications@github.com
wrote:

There is setting to disable this in most Mac applications by clicking in
the text field and going to Substitutions > Smart Quotes, but I'd agree
that is super annoying. [image: 👍]

[image: screen shot 2015-09-01 at 5 53 25 pm]
https://cloud.githubusercontent.com/assets/80459/9619130/6c80c0ac-50d2-11e5-966c-b0bce760b900.png


Reply to this email directly or view it on GitHub
#45 (comment)
.

@stephenyeargin
Copy link
Member

Fixed in v2.1.5

@kashizui
Copy link
Author

kashizui commented Sep 1, 2015

Thanks for the super fast response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants