CoffeeScript -> JS #13
Conversation
|
@TimvdLippe If you have a moment, tell me a bit more about the Hubot v3 requirements (namely, where I can keep up with them). I maintain several packages and am curious how much work is ahead. 😬 |
| @@ -14,7 +14,7 @@ | |||
| }, | |||
| "dependencies": {}, | |||
| "peerDependencies": { | |||
| "hubot": "2.x" | |||
| "hubot": "3.x" | |||
There was a problem hiding this comment.
Will this make it no longer viable for v2 Hubots?
There was a problem hiding this comment.
Yes that is correct.
index.js
Outdated
| * DS205: Consider reworking code to avoid use of IIFEs | ||
| * DS207: Consider shorter variations of null checks | ||
| * Full docs: https://github.com/decaffeinate/decaffeinate/blob/master/docs/suggestions.md | ||
| */ |
There was a problem hiding this comment.
We can probably delete this block. As an aside, the new hubot:script generator probably has a better version of this?
There was a problem hiding this comment.
Yup did this locally but forgot to do it here.
|
@stephenyeargin Basically as far as I can understand, Hubot 3 is the same as Hubot 2, but all the coffeescript related stuff is removed. With these changes, I was able to make it run again. The other breaking changes are described at https://github.com/hubotio/hubot/releases/tag/v3.0.0 |
Yeah, I noticed that in core. Wasn't sure what the plan was for the community packages if they had to move to ES6 or if they were fine as-is. The @hubot-scripts/hubot-youtube If you have a moment to weigh in on Hubot^Next as it relates to packages, that would be enlightening. ✨ |
There certainly is, but sadly Hubot 3 is incapable of consuming a package with just coffeescript files. This forces the package to convert to JS instead 😢 |
|
Weird. I feel like that'd be a bigger announcement somewhere than what's in the release notes. 🤔 |
|
@stephenyeargin Friendly ping on this PR 😄 |
|
I'd really hoped for a bit of feedback from the core Hubot folks to see if the CoffeeScript deprecation was permanent/required for future work. This isn't a terribly consequential package, so I'll go forward with merging. |
|
@stephenyeargin Awesome, thanks for the quick response! |
|
Released with |
This PR updates all coffeescript files to JS ES6 to be compatible with Hubot 3.
Fixes #12