Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No tests! #12

Closed
clarkd opened this issue May 1, 2018 · 7 comments
Closed

No tests! #12

clarkd opened this issue May 1, 2018 · 7 comments

Comments

@clarkd
Copy link
Member

clarkd commented May 1, 2018

We don't currently have any unit tests - with API wrappers like this, they can be difficult to add as you'd have to mock the HubSpot API.

But... we could look at using the HubSpot demo instance (they provide a demo API key etc.) so we could make actual API calls etc.

Any thoughts?

@bfutrell70
Copy link

Sounds good to me - just having tried the demo key using Postman it appears for GET calls anyway the results are repeatable.

@clarkd
Copy link
Member Author

clarkd commented May 1, 2018

That's good - I think we can avoid any difficulties with repeatability by designing the tests so we only rely on the data we create, e.g.

  1. Create a contact
  2. Update the same contact
  3. Delete the same contact

@bfutrell70
Copy link

Is there a preference as to which testing framework to use?

@clarkd
Copy link
Member Author

clarkd commented Jun 6, 2018

I'm pretty flexible really - we use VSTest with Moq for some internal projects but have seen a lot of XUnit around too. Do you have a preference or any relevant experience?

@bfutrell70
Copy link

bfutrell70 commented Jun 6, 2018 via email

@clarkd
Copy link
Member Author

clarkd commented Jun 6, 2018

To keep the barrier to entry low and enable anyone to write tests I think looking at VSTest would be a great start. Are you thinking of kicking something off? I'd been to help get the ball rolling so let me know if there's anything I can provide!

@bfutrell70
Copy link

As soon as I can find a spare moment... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants