Full stack/refactor internal session vars - adapt frontend code to botState data model #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanbasten17
changed the title
asastre
approved these changes
Oct 22, 2021
| updateSession(merge(initialSession, session)) | ||
| } | ||
| if (initialBotState) { | ||
| updateBotState({ ...initialBotState, ...botState }) |
There was a problem hiding this comment.
Why not doing a merge here?
vanbasten17
force-pushed
the
full-stack/refactor-internal-session-vars-backend
branch
from
a295c73
to
ee9657a
Compare
vanbasten17
force-pushed
the
full-stack/refactor-internal-session-vars-frontend
branch
from
9ff6e5d
to
dde5fa6
Compare
vanbasten17
changed the base branch from
full-stack/refactor-internal-session-vars-backend
to
master
vanbasten17
changed the base branch from
master
to
full-stack/refactor-internal-session-vars-backend
vanbasten17
merged commit e85f900
into
full-stack/refactor-internal-session-vars-backend
vanbasten17
deleted the
full-stack/refactor-internal-session-vars-frontend
branch
vanbasten17
added a commit
that referenced
this pull request
Oct 29, 2021
…State data model (#1966) * chore(dev-template): remove warnings in Actions and sort imports * chore(dev-template): project changes regarding botState data model * chore(core): split data models into User, Session and BotState * chore(api): changes regarding botState in botonic/api * chore(core): core-bot and router logic to work with botState * chore(core): adapt tests to work with botState model, disabling handoff tests for 1.0 * Full stack/refactor internal session vars - adapt frontend code to botState data model (#1967) * chore(react): changes in webchat regarding move to botState model * refactor(core/api/dev-template): remove initial locale and minor fixes * refactor(react): remove locale from initial session and make use of merge func
vanbasten17
added a commit
that referenced
this pull request
Oct 29, 2021
…o be changed into experimental (#1948) * chore(react): move necessary files to be changed into experimental and update imports * chore: add more necessary files to be changed * Full stack/refactor internal session vars - adapt backend code to botState data model (#1966) * chore(dev-template): remove warnings in Actions and sort imports * chore(dev-template): project changes regarding botState data model * chore(core): split data models into User, Session and BotState * chore(api): changes regarding botState in botonic/api * chore(core): core-bot and router logic to work with botState * chore(core): adapt tests to work with botState model, disabling handoff tests for 1.0 * Full stack/refactor internal session vars - adapt frontend code to botState data model (#1967) * chore(react): changes in webchat regarding move to botState model * refactor(core/api/dev-template): remove initial locale and minor fixes * refactor(react): remove locale from initial session and make use of merge func
This was referenced Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adapt frontend code to work with BotState internals instead of Session. Handoff features has been changed partially as they are not totally implemented nor production ready
Context
Part of splitting botonic data models into User, Session and BotState.
Approach taken / Explain the design
To document / Usage example
Testing
The pull request...