Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full stack/refactor internal session vars - preparation: move files to be changed into experimental #1948

Merged
merged 3 commits into from
Oct 29, 2021

Conversation

vanbasten17
Copy link
Contributor

@vanbasten17 vanbasten17 commented Oct 13, 2021

NOTE: Nothing to review here, just moved necessary files to be changed into @botonic/react/src/experimental

Description

  • Duplication of files to be changed in src/experimental within @botonic/react.

Context

Part of splitting botonic data models into User, Session and BotState.

Approach taken / Explain the design

To document / Usage example

Testing

The pull request...

  • has unit tests
  • has integration tests
  • doesn't need tests because... [provide a description]

@vanbasten17 vanbasten17 force-pushed the full-stack/refactor-internal-session-vars branch 2 times, most recently from bc67204 to 6991d33 Compare October 14, 2021 15:08
Base automatically changed from full-stack/refactor-router-pt2-sort-tests to full-stack/refactor-router-pt2 October 14, 2021 15:09
Base automatically changed from full-stack/refactor-router-pt2 to full-stack/refactor-router October 14, 2021 15:14
@vanbasten17 vanbasten17 force-pushed the full-stack/refactor-internal-session-vars branch from 6991d33 to 417a670 Compare October 14, 2021 15:16
Base automatically changed from full-stack/refactor-router to master October 14, 2021 15:20
@vanbasten17 vanbasten17 force-pushed the full-stack/refactor-internal-session-vars branch from 417a670 to 8aa288a Compare October 14, 2021 15:28
@github-actions
Copy link

github-actions bot commented Oct 14, 2021

Unit Test Results

  1 files  ±0    7 suites  ±0   3m 44s ⏱️ +33s
32 tests ±0  32 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3b5fb3b. ± Comparison against base commit 00be83e.

♻️ This comment has been updated with latest results.

@vanbasten17 vanbasten17 force-pushed the full-stack/refactor-internal-session-vars branch from 8aa288a to e16d3f3 Compare October 19, 2021 10:57
@vanbasten17 vanbasten17 changed the title Full stack/refactor internal session vars (WIP) Full stack/refactor internal session vars preparation - move files to be changed in botonic-react Oct 19, 2021
@vanbasten17 vanbasten17 changed the title Full stack/refactor internal session vars preparation - move files to be changed in botonic-react Full stack/refactor internal session vars preparation - move files to be changed into experimental Oct 19, 2021
@vanbasten17 vanbasten17 changed the title Full stack/refactor internal session vars preparation - move files to be changed into experimental Full stack/refactor internal session vars - preparation: move files to be changed into experimental Oct 19, 2021
@vanbasten17 vanbasten17 marked this pull request as ready for review October 19, 2021 13:24
@vanbasten17 vanbasten17 marked this pull request as draft October 19, 2021 13:24
@vanbasten17 vanbasten17 marked this pull request as ready for review October 20, 2021 09:48
@vanbasten17 vanbasten17 force-pushed the full-stack/refactor-internal-session-vars branch from e16d3f3 to 3b5fb3b Compare October 29, 2021 15:06
…State data model (#1966)

* chore(dev-template): remove warnings in Actions and sort imports

* chore(dev-template): project changes regarding botState data model

* chore(core): split data models into User, Session and BotState

* chore(api): changes regarding botState in botonic/api

* chore(core): core-bot and router logic to work with botState

* chore(core): adapt tests to work with botState model, disabling handoff tests for 1.0

* Full stack/refactor internal session vars - adapt frontend code to botState data model (#1967)

* chore(react): changes in webchat regarding move to botState model

* refactor(core/api/dev-template): remove initial locale and minor fixes

* refactor(react): remove locale from initial session and make use of merge func
@vanbasten17 vanbasten17 merged commit 56d29a3 into master Oct 29, 2021
@vanbasten17 vanbasten17 deleted the full-stack/refactor-internal-session-vars branch October 29, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants