Fix errors introduced to tests

hubverse-org · Apr 5, 2024 · 7e12730 · 7e12730
1 parent 176c893
commit 7e12730
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/tests/testthat/test-simple_ensemble.R b/tests/testthat/test-simple_ensemble.R
@@ -93,7 +93,7 @@ test_that("component model outputs and resulting ensemble model outputs have ide
   expected_output_type_ids <- sort(unique(quantile_outputs$output_type_id))
 
   actual_output_type_ids <- quantile_outputs |>
-    simple_ensemble(quantile_outputs, weights = NULL,
+    simple_ensemble(weights = NULL,
                     weights_col_name = NULL,
                     model_id = "hub-ensemble",
                     task_id_cols = NULL) |>

diff --git a/tests/testthat/test-validate_ensemble_inputs.R b/tests/testthat/test-validate_ensemble_inputs.R
@@ -65,5 +65,5 @@ test_that("error if models provide different output_type_ids", {
   model_outputs |>
     dplyr::filter(!(model_id == "b" & abs(output_type_id - 0.5) < 1e-6)) |>
     validate_output_type_ids(task_id_cols = c("location", "horizon", "target", "target_date")) |>
-    expect_no_error()
+    expect_error()
 })