-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hmisc dependency #102
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
===========================================
- Coverage 87.83% 66.54% -21.30%
===========================================
Files 5 6 +1
Lines 148 275 +127
===========================================
+ Hits 130 183 +53
- Misses 18 92 +74 ☔ View full report in Codecov by Sentry. |
@annakrystalli is it ok that the functions from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's address the linting issues that are introduced by changes in this PR before merging it in.
I also just filed a separate issue, #103 , to fix the other linting issues, which are in existing stuff in the package -- my vote is that it'd be good to take care of that issue next so that we get to a place where linting checks pass. Ideally, it'd really be nice to do that other one, get that merged in, and then merge main into this branch so that the linting check fully passes. But I'm personally ok with merging a PR where the lint check is failing as long as it doesn't add new linting issues.
Linting issues have been fixed with pull request #105! |
Solves Issue #55