Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timezone information #4

Closed
LucieContamin opened this issue Nov 16, 2022 · 3 comments · Fixed by #23 or #24
Closed

timezone information #4

LucieContamin opened this issue Nov 16, 2022 · 3 comments · Fixed by #23 or #24

Comments

@LucieContamin
Copy link

Per suggestions from Koji, should we add a "timezone" information field in the admin.json schema? As different Hubs are on different timezome, it might be interesting to store that information especially if, for example, the submission date start/end date of the Hub need to be precise.

@nickreich
Copy link
Contributor

Agree that this should be in admin.json

@annakrystalli
Copy link
Member

Need a valid timezone array.

@annakrystalli
Copy link
Member

Have now added a timezone property.

Couple of questions:

  • How should we handle daylight savings? Although I've gone for UTC, I'm now questioning it as it's very difficult to account for daylight savings as not all countries observe them and those who do do not change on the same day, which itself varies form year to year! I feel the safest is to actually use TZ database names (e.g. Europe/London), which are location based. R can use these to convert dates to other timezones, accounting for daylight savings. It does mean a really long list of potential valid values in the schema though. Have a look at use tz database names & enum list of timezones. #4 #24 for a possible implementation of this proposal.
  • Are we making timezone required? I'm opting for yes for now.

annakrystalli added a commit that referenced this issue Dec 7, 2022
…list

use tz database names & enum list of timezones. #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants