Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume objects with no type field are not clones #436

Merged
merged 1 commit into from
Jun 25, 2022

Conversation

GriffinRichards
Copy link
Collaborator

Without this, if someone were to port the "clone object" feature to pokeemerald they'd have to add this field to every object themselves.

This has the additional benefit of not treating all of pokefirered's objects as invalid while waiting for pret/pokefirered#484 to be merged.

@garakmon garakmon merged commit b20df82 into huderlem:master Jun 25, 2022
@GriffinRichards GriffinRichards deleted the clone-default branch June 25, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants