Fix timeout pass-through with [Command] #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CancellationTokens provided by Mjolnir (via the Timeout property for [Command]) weren't being passed through to CancellationToken parameters in Bifrost service calls. The Mjolnir token will now replace empty or null parameter values in Bifrost method calls if a CancellationToken parameter exists. If a token was explicitly provided to the call, it won't be replaced.
Change some test class visibilities and sleep times.
|
Merged into #12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CancellationTokens provided by Mjolnir (via the Timeout property for
[Command]) weren't being passed through to CancellationToken parameters inBifrost service calls.
The Mjolnir token will now replace empty or null parameter values in
Bifrost method calls if a CancellationToken parameter exists. If a token
was explicitly provided to the call, it won't be replaced.
Also updates the README for this project to have examples and useful content.