Remove dependency on Nito.AsyncEx #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It griefed us with some conflicts in Hudl.QueuedServices with some Bcl stuff. We don't really need it, either.
robhruska
added a commit
that referenced
this pull request
Jan 25, 2014
Remove dependency on Nito.AsyncEx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It griefed us with some conflicts in
Hudl.QueuedServiceswith some Bclstuff. We don't really need it, either.
Also added two test WebApp projects to test that we retain context after
awaiting a call that has.ConfigureAwait(false)called on it downstream.TestMvc40WebAppwas created targeting 4.0 and then given theaspnet:UseTaskFriendlySynchronizationContextconfiguration value. Itstest/contextroute should print "Success".TestMvc45WebAppwas created targeting 4.5 and has<httpRuntime targetFramework="4.5"/>. Itstest/contextroute should print "Success".I verified that
TestMvc40WebAppinstead throws aNullReferenceExceptionwhen the configured value is not present.