Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-generic logger name for better filtering #35

Merged
merged 1 commit into from
Dec 2, 2014

Conversation

robhruska
Copy link
Member

Fixes #32.

The ILog used by Command is just a single logger for all possible Commands, which makes any log filtering to hide/show logs for specific commands difficult.

This changes the log name to incorporate the command's name into it.

Old

2014-11-30 00:00:49,075 hostname [INFO ] [Hudl.Mjolnir.Command.Command`1] InvokeAsync Command=group-name.CommandName Breaker=breaker-name Pool=pool-name Timeout=15000

New

2014-11-30 00:00:49,075 hostname [INFO ] [Hudl.Mjolnir.Command.group-name.CommandName] InvokeAsync Command=group-name.CommandName Breaker=breaker-name Pool=pool-name Timeout=15000

robhruska added a commit that referenced this pull request Dec 2, 2014
Non-generic logger name for better filtering
@robhruska robhruska merged commit b6d56c1 into next Dec 2, 2014
@robhruska robhruska deleted the BetterCommandLoggerName branch December 2, 2014 20:43
@robhruska robhruska mentioned this pull request Dec 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant