What's the cause of CommandFailedException #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne the reason for a TaskCancellationException
| Command = Name, | ||
| Timeout = Timeout.TotalMilliseconds, | ||
| Status = status, | ||
| CommandCancellationReason = tokenSourceCancelled ? CommandCancellationReason.TimeoutCancellation : CommandCancellationReason.CallerTokenCancellation, |
There was a problem hiding this comment.
If we wanted to DRY this up a bit, we could just make this field a "FailureReason" or something (i.e. not timeout-specific) and set it to "Faulted" for non-cancellations.
|
I think we should change the exception message for known timeouts from "Command canceled" to "Command timed out". That's more visible in our logs than exception data, and will be more helpful for quick incident diagnosis. |
|
I've now added specific exceptions for each case (timeout, cancelled, rejected). Each of these derives from CommandFailedException, so that there isn't a breaking change. I've kept the Status inside of the base class as well, again to avoid a breaking change. |
lewislabs
added a commit
that referenced
this pull request
Oct 23, 2015
Find out the true cause of a CommandFailedException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mjolnir wraps exceptions thrown by its invoked methods in a CommandFailedException. In cases where the thrown exception was of type OperationCancelledException, we want to know the reason for this cancellation. Was the cancellation made explicitly by the user or was it tripped by Mjolnir's preset timeout.
This change adds an additional piece of data to the CommandFailedException to express the cause of cancellation.