Mjolnir 1.6

[robhruska]

Minor updates (non-breaking):

• Introduce ICommand<TResult> and apply to Command<TResult> so we can test things mo' better.
• Stop logging command exceptions to avoid duplicate traces.
• Drop the unit test execution time by about 20 seconds.

Major updates (non-breaking):

• Ability to decorate an interface with a [Command] attribute to automatically proxy the call through a Command.

  Example:

  [BifrostService]
  [Command("recruit", "recruit-team", 15000)]
  public interface IRecruitTeamService
  {
      [BifrostPath("bifrost/recruit/recruit-team/get-team
      Task<RecruitTeamDto> GetTeam(long teamId);
  
      // ...
  }
  
  [Command("mongo", "recruiting-boards", 15000)]
  public interface IBoardDao
  {
      [CommandTimeout(5000)] // Allow base timeout to be overridden.
      BaseBoard GetBoardById(string id, long teamId);
  
      BaseBoard CreateBoard(BaseBoard board);
  
      // ...
  }
  

  • Right now, this will only work for interfaces whose implementations are grabbed via a service locator (e.g. Bifrost's ServiceLocator or DaoFactory).
  • I imagine the Bifrost ServiceLocator processing of the attributes will only apply the command proxy to calls that are going to be remote; it won't proxy if they're local.
  • The proxying supports both Task and non-Task return types. If the method returns a Task, it'll use InvokeAsync(). Otherwise it'll use Invoke().
  • We might be able to rethink CancellationTokens and whether or not we need to encourage them on Bifrost service methods now. Not sure here yet, haven't thought about it.

Side note - we'll probably want to change how we use ServiceLocator a bit to make it more testable. Callers should probably keep a local IServiceLocator that can be injected for unit testing.