Func<TResult> as an alternative to Command inheritance #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
robhruska
commented
Sep 18, 2017
| @@ -384,7 +443,7 @@ public Task<CommandResult<TResult>> InvokeReturnAsync<TResult>(AsyncCommand<TRes | |||
|
|
|||
| // failureModeForMetrics is just so we can send "throw" or "return" along with the metrics | |||
| // event we fire for CommandInvoke(). Not really intended for use beyond that. | |||
| private async Task<TResult> InvokeAsync<TResult>(AsyncCommand<TResult> command, InformativeCancellationToken ct, OnFailure failureModeForMetrics) | |||
| private async Task<TResult> InvokeAsync<TResult>(AsyncCommand<TResult> command, OnFailure failureModeForMetrics, InformativeCancellationToken ct) | |||
There was a problem hiding this comment.
These changes aren't specific to this PR, but I noticed that the Invoke and InvokeAsync methods were inconsistent with argument order.
robhruska
commented
Sep 18, 2017
| { | ||
| private readonly Func<CancellationToken?, Task<TResult>> _func; | ||
|
|
||
| public DelegateAsyncCommand(string group, Func<CancellationToken?, Task<TResult>> func) : base(group, group, TimeSpan.FromMilliseconds(2000)) |
There was a problem hiding this comment.
Timeout here (and below) should reference the default here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some situations (e.g. adapter code) where it's easier to work only with interfaces. This PR experiments with overloads to
Invoke*()methods that takeFunc<TResult>delegates instead of a class that implementsSyncCommandorAsyncCommand.Opening for review and comment. This may be merged into #60.