-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lower required net framework #70
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows consumption of the package by .NET Framework 4.5.1.
Make config extendable
Fix exception serialization. Remove sdk version from global.json
lewislabs
approved these changes
Feb 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal for this PR is to make it easier to consume the Mjolnir library on more platforms. It will be possible to use it by everything that targets netstandard1.2 or greater.
We've also made properties of the
MjolnirConfiguration
class virtual and the class is no longer sealed. This will allow easier adaptation of the configuration of Mjolnir.From this version we also include a
<FileVersion>
and<AssemblyVersion>
locked on v3.0.0.0. This is for easier dependency management with consuming applications.All changes here are backwards compatible.
Changes
Enhancements
MjolnirConfiguration
class and remove thesealed
keyword from the class.netstandard1.2
Bug fixes
Other