Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower required net framework #70

Merged
merged 13 commits into from
Feb 15, 2018
Merged

Lower required net framework #70

merged 13 commits into from
Feb 15, 2018

Conversation

damtur
Copy link
Contributor

@damtur damtur commented Feb 13, 2018

Description

The goal for this PR is to make it easier to consume the Mjolnir library on more platforms. It will be possible to use it by everything that targets netstandard1.2 or greater.
We've also made properties of the MjolnirConfiguration class virtual and the class is no longer sealed. This will allow easier adaptation of the configuration of Mjolnir.
From this version we also include a <FileVersion> and <AssemblyVersion> locked on v3.0.0.0. This is for easier dependency management with consuming applications.

All changes here are backwards compatible.

Changes

Enhancements

  • Add virtual modifiers to MjolnirConfiguration class and remove the sealed keyword from the class.
  • Lower target framework to netstandard1.2
  • Add a new protected constructor to AsyncCommand and SyncCommand to allow for extensions of the classes to override the command name.

Bug fixes

  • Fix bug with not being able to serialize exception due to GroupKey not being serializable

Other

  • Remove global.json content (specific SDK requirement)
  • Include File and assembly version in csproj.

Copy link
Contributor

@lewislabs lewislabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lewislabs lewislabs merged commit 6af36cb into master Feb 15, 2018
@jamiegs jamiegs deleted the LowerRequiredNetFramework branch October 23, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants