Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linear isotropic hardening #99

Merged
merged 5 commits into from
Jul 31, 2021
Merged

Linear isotropic hardening #99

merged 5 commits into from
Jul 31, 2021

Conversation

Sina-av
Copy link
Contributor

@Sina-av Sina-av commented Jul 30, 2021

Hi!
As the code already has some hardening laws, to be complete and easy to use I added the isotropic hardening law.
Based on works of Yin et al. and Ambati et al. degradation function is not applied to the yield surface. (But it can be done easily)
Please, let me know if you think this is a good idea, or if it needs work.
Thanks.

Linear isotropic hardening file added.
C file added
@moosebuild
Copy link
Collaborator

Job Precheck on 706ab0e : invalidated by @hugary1995

Seems to be unrelated.

@hugary1995
Copy link
Owner

hugary1995 commented Jul 30, 2021

Thank you very much for your contribution! This looks good to me. We didn't include a linear hardening law because we thought it is a special case of PowerLawHardening. But maybe their underlying energies are different.

To merge your contribution, all of the tests below have to pass. There are several things you need to do to get the tests pass:

  1. All pull request must reference a valid issue number. If none of the existing issues matches your pull request, you can create one. This time, I have created an issue for you Add a linear hardening law #100, so you can directly reference it. To reference an issue, you will need to modify an existing commit message (or create a new commit message) to say something like ref #100, so that the test will pass.
  2. All C++ files in RACCOON must be clang-formatted. If you click on "Details" to the right of "
    clang-format / Check clang-format (src) (pull_request)", you can see which of your file doesn't comply with clang-format. After you've corrected the format of that file, you can commit and push it, and that test will pass.

Please don't hesitate to ask if you have any questions. Thanks again.

Copy link
Owner

@hugary1995 hugary1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor requests. Otherwise this looks perfect.

Clang format and license added
clang format and lincense added
@hugary1995
Copy link
Owner

Okay this looks good to me now. I'll wait for the final test to pass before I merge it.

I'm expecting the documentation test to fail, but that's fine for now.

  • I'll add a documentation page for this new hardening model in a separate PR.
  • I'll also add a regression test for this model so that it doesn't break in the future.

@Sina-av Thanks for your contribution.

@hugary1995 hugary1995 merged commit 7c3a4da into hugary1995:master Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants