feat: support publish_hubble_image to dockerhub automatically (V2) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
imbajin
reviewed
Sep 20, 2023
|
|
||
| steps: | ||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v2 |
There was a problem hiding this comment.
also update other ci actions thx
| uses: docker/setup-buildx-action@v2 | ||
|
|
||
| - name: Login to Docker Hub | ||
| uses: docker/login-action@v2 |
| password: ${{ secrets.DOCKERHUB_PASSWORD }} | ||
|
|
||
| - name: Checkout latest | ||
| uses: actions/checkout@v3 |
There was a problem hiding this comment.
docker/build-push-action@v5
This script is also updated.
BTW, the cache seems not speed up the build process.
There was a problem hiding this comment.
docker/build-push-action@v5 This script is also updated. BTW, the cache seems not speed up the build process.
yep, the cache is not work now (could submit a issue for it, and try to solve it later) 😢
simon824
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change
Logic is the same as the pr to publish server image: publish_server_image, which can avoid publish images repeatedly.
Before Merge
Before merge, admin should set the public var
LAST_HUBBLE_HASHas an empty value or test value.