Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bars have color red and never completed to 100% #5117

Closed
echatzikyriakidis opened this issue Oct 14, 2022 · 5 comments
Closed

Progress bars have color red and never completed to 100% #5117

echatzikyriakidis opened this issue Oct 14, 2022 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@echatzikyriakidis
Copy link

Describe the bug

Progress bars after transformative operations turn in red and never be completed to 100%

Steps to reproduce the bug

from datasets import load_dataset

load_dataset('rotten_tomatoes', split='test').filter(lambda o: True)

Expected results

Progress bar should be 100% and green

Actual results

Progress bar turn in red and never completed to 100%

Environment info

  • datasets version: 2.6.1
  • Platform: Linux-5.10.133+-x86_64-with-Ubuntu-18.04-bionic
  • Python version: 3.7.14
  • PyArrow version: 6.0.1
  • Pandas version: 1.3.5
@echatzikyriakidis echatzikyriakidis added the bug Something isn't working label Oct 14, 2022
@david1542
Copy link
Contributor

david1542 commented Oct 16, 2022

Hi @echatzikyriakidis, thanks for submitting the issue.
Which shell are you using exactly? I tried to run the command you sent, but I don't see colors at all 🧐

I tried from bash and zsh as well.

@echatzikyriakidis
Copy link
Author

Hi @david1542 ,

I use Google Colab.

@david1542
Copy link
Contributor

david1542 commented Oct 16, 2022

Got it. I created a PR that fixes this issue. Turns out that the wrapping logic for the inner loop was slightly incorrect.

@echatzikyriakidis
Copy link
Author

Thank you!

@11301858
Copy link

Hello @mariosasko

I am still facing this issue. Was this problem fixed?

Screen Shot 2024-06-19 at 11 35 57 AM

I cleared the hugging face cache before running, and no error message was given. Let me know if you need a minimal repro of my code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants