Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: adaptor list should be an enum #69

Closed
McPatate opened this issue Feb 5, 2024 · 8 comments · Fixed by #70
Closed

refactor: adaptor list should be an enum #69

McPatate opened this issue Feb 5, 2024 · 8 comments · Fixed by #70

Comments

@McPatate
Copy link
Member

McPatate commented Feb 5, 2024

const TGI: &str = "tgi";
const HUGGING_FACE: &str = "huggingface";
const OLLAMA: &str = "ollama";
const OPENAI: &str = "openai";
const DEFAULT_ADAPTOR: &str = HUGGING_FACE;
could be replaced by an enum

@jeremyelalouf
Copy link
Contributor

Hi @McPatate, if it is still needed (which i think), I would be more than happy to do it :)

@McPatate McPatate linked a pull request Feb 7, 2024 that will close this issue
@McPatate
Copy link
Member Author

McPatate commented Feb 7, 2024

Ah forgot to link the issue with my PR, sorry, I just did it yesterday. Thanks for offering though!

I'll try to keep my list of features to do up to date so that people can contribute if they want :)

@McPatate McPatate closed this as completed Feb 7, 2024
@jeremyelalouf
Copy link
Contributor

jeremyelalouf commented Feb 7, 2024

Okay nice although I'm sad, i really wanted to participate, do you know a good first issue for me @McPatate ?

@McPatate
Copy link
Member Author

McPatate commented Feb 9, 2024

Not that I can think of at the moment, sorry!

@McPatate
Copy link
Member Author

Actually there might be a thing, @rojas-diego has offered to add support for multiple encodings in #50.

Not sure if he's still aiming to do it, feel free to take a stab at it :)

The gist: https://gist.github.com/rojas-diego/04d9c4e3fff5f8374f29b9b738d541ef

@rojas-diego
Copy link

Hi @McPatate and @jeremyelalouf!

Funny enough Jeremy and I studied at school together in Paris. I'd be happy to get on a call with you Jeremy anytime to collaborate on merging my Gist if you're interested in contributing to the repo!

@McPatate
Copy link
Member Author

Epitech est un petit monde :)

@jeremyelalouf
Copy link
Contributor

Hi @McPatate and @rojas-diego,

Of course, I'm excited about the opportunity to collaborate with you Diego. If there's any way I can assist you, please don't hesitate to reach out 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants