Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on question_answering.ipynb #39

Open
sam351 opened this issue May 8, 2021 · 0 comments
Open

Question on question_answering.ipynb #39

sam351 opened this issue May 8, 2021 · 0 comments

Comments

@sam351
Copy link

sam351 commented May 8, 2021

Hi, Thank you for awesome example notebooks!
I'm reviewing the notebook about question answering.
https://github.com/huggingface/notebooks/blob/master/examples/question_answering.ipynb

In the notebook, you used postprocess_qa_predictions function to post-process the prediction of model.
(The function is defined at 25th cell in the notebook.)
And the function initializes valid_answers list(local var) for each example, not feature.
However, I thought that valid_answers should be initialized for each feature, since certain valid answer for one feature's context might not exist in another feature's context.

Is there anything that I misundertood?

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant