Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set LayerNorm's eps to a number that is larger than 6e-5 #115

Open
gejinchen opened this issue Jun 29, 2022 · 2 comments
Open

Set LayerNorm's eps to a number that is larger than 6e-5 #115

gejinchen opened this issue Jun 29, 2022 · 2 comments

Comments

@gejinchen
Copy link
Contributor

gejinchen commented Jun 29, 2022 •
edited
Loading

Currently, many LayerNorm's eps are smaller than 6.1e-5 (smallest fp16 value), which might cause underflow.
@gejinchen gejinchen changed the title As LayerNorm's eps to a number Set LayerNorm's eps to a number that is larger than 6e-5 Jun 29, 2022
@jimypbr
Copy link
Contributor

jimypbr commented Jul 6, 2022

@michaelbenayoun this is something that could be done easily as a torch.fx transform?

@michaelbenayoun
Copy link
Member

I would think this is something handled by pytorch, but to answer you @jimypbr, yes definitely!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jimypbr @gejinchen @michaelbenayoun