Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deepspeed] replaced deprecated init arg #13587

Merged
merged 3 commits into from
Sep 16, 2021

Conversation

stas00
Copy link
Contributor

@stas00 stas00 commented Sep 15, 2021

deepspeed 0.5.2 deprecated config in zero.Init() in favor of config_dict_or_path - deepspeed 0.5.3 fixed a bug in the previous version related to that microsoft/DeepSpeed#1373. So this PR updates the arg and ups the minimal requirement.

0.5.3 fixes a bug in zero_to_fp32.py introduced by 0.5.2

The ci failure is unrelated.

@sgugger, @LysandreJik

@stas00 stas00 marked this pull request as ready for review September 16, 2021 18:49
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating!

@stas00 stas00 merged commit bec2e3f into huggingface:master Sep 16, 2021
@stas00 stas00 deleted the ds-init-config branch September 16, 2021 19:12
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 13, 2022
* [deepspeed] replaced deprecated init arg

* Trigger CI
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 27, 2022
* [deepspeed] replaced deprecated init arg

* Trigger CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants