Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use config_dict_or_path for deepspeed.zero.Init #13614

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

aphedges
Copy link
Contributor

What does this PR do?

While #13587 fixes one DeepSpeed warning, it missed a similar one. This applies the same change of config -> config_dict_or_path in another location.

Who can review?

@sgugger (same reviewer as #13587)

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@sgugger
Copy link
Collaborator

sgugger commented Sep 17, 2021

I'll let @stas00 merge this after he double-checks it's good :-)

@sgugger sgugger requested a review from stas00 September 17, 2021 11:27
Copy link
Contributor

@stas00 stas00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this omission, @aphedges!

@stas00 stas00 merged commit ce32c69 into huggingface:master Sep 17, 2021
@aphedges
Copy link
Contributor Author

@stas00, you're welcome! Thanks for the review!

Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants