Update modeling_flax_wav2vec2.py #13680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conv kernel_size to Tuple, Flax Version 0.3.5 breaking change, https://github.com/google/flax/releases/tag/v0.3.5
|
Thanks a lot for the PR @kamalkraj! @patil-suraj - I checked that FlaxViT and FlaxCLIP already use Tuples so this PR should cover all Flax Conv modules |
patrickvonplaten
approved these changes
Sep 21, 2021
|
Thanks for the quick fix @kamalkraj ! |
Narsil
pushed a commit
to Narsil/transformers
that referenced
this pull request
Sep 25, 2021
conv kernel_size to Tuple, Flax Version 0.3.5 breaking change, https://github.com/google/flax/releases/tag/v0.3.5
stas00
pushed a commit
to stas00/transformers
that referenced
this pull request
Oct 12, 2021
conv kernel_size to Tuple, Flax Version 0.3.5 breaking change, https://github.com/google/flax/releases/tag/v0.3.5
Albertobegue
pushed a commit
to Albertobegue/transformers
that referenced
this pull request
Jan 13, 2022
conv kernel_size to Tuple, Flax Version 0.3.5 breaking change, https://github.com/google/flax/releases/tag/v0.3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conv kernel_size to Tuple,
Flax Version 0.3.5 breaking change, https://github.com/google/flax/releases/tag/v0.3.5
PR #13393
test failed link - https://app.circleci.com/pipelines/github/huggingface/transformers/28187/workflows/e0df5370-aebd-4fe7-99fb-ff49e2ddcec8/jobs/276846
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@patrickvonplaten