Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace assertions with valueError Exeptions #14117

Merged
merged 2 commits into from
Oct 22, 2021
Merged

Replace assertions with valueError Exeptions #14117

merged 2 commits into from
Oct 22, 2021

Conversation

jyshdewangan
Copy link
Contributor

@jyshdewangan jyshdewangan commented Oct 22, 2021

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@sgugger Please review

@jyshdewangan
Copy link
Contributor Author

jyshdewangan commented Oct 22, 2021

Contributes toward fixing #12789

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot foe fixing those!

@sgugger sgugger merged commit fa4abdb into huggingface:master Oct 22, 2021
@jyshdewangan
Copy link
Contributor Author

Hey @sgugger, can you please add hactoberfest-accepted tag also?

@sgugger
Copy link
Collaborator

sgugger commented Oct 26, 2021

According to the rules, it's not necessary when the PR has been approved and merged:

A pull request is considered approved once it has an overall approving review from maintainers, or has been merged by maintainers, or has been given the 'hacktoberfest-accepted' label.*

Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 27, 2022
* Replace assertions with valueError Exeptions

* Reformatted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants