Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand dynamic supported objects to configs and tokenizers #14296

Merged
merged 6 commits into from Nov 8, 2021

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Nov 5, 2021

What does this PR do?

This PR expands support for dynamic objects (from just models to models, configurations and tokenizers). The API to enable this is still a bit hack-ish (see tests) but this will be put together with the new register API of the Auto classes in a followup PR, which should make everything all fit together.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, great work on the tests.

Happy to see part 3/4 (the last being the register!) is being wrapped up, really looking forward to this.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes for the from_config

@sgugger sgugger merged commit dfb00bf into master Nov 8, 2021
@sgugger sgugger deleted the more_custom_code branch November 8, 2021 20:28
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 27, 2022
…ce#14296)

* Dynamic configs

* Add config test

* Better tests

* Add tokenizer and test

* Add to from_config

* With save
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants