[TFWav2Vec2Model] Fix input shapes in TFWav2Vec2WeightNormConv1D #14319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickvonplaten
approved these changes
Nov 8, 2021
Albertobegue
pushed a commit
to Albertobegue/transformers
that referenced
this pull request
Jan 27, 2022
…gingface#14319) * Add paddings to input shapes * Add padding comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Context
After updating to TF 2.7 the tests started failing with
ValueError('One of the dimensions in the output is <= 0...')which is caused by the recently added check tokeras.layers.Conv.build()https://github.com/keras-team/keras/blob/v2.7.0/keras/layers/convolutional.py#L197This PR fixes the input shapes passed during
TFWav2Vec2WeightNormConv1D.build()to account for padding.