Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GPTJForQuestionAnswering #14503

Merged
merged 8 commits into from
Dec 6, 2021
Merged

Add GPTJForQuestionAnswering #14503

merged 8 commits into from
Dec 6, 2021

Conversation

tucan9389
Copy link
Contributor

@tucan9389 tucan9389 commented Nov 23, 2021 •
edited
Loading

What does this PR do?

  • Add GPTJForQuestionAnswering class for GPTJ upstream and QA downstream task

Fixes # (issue)

Before submitting

  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@patrickvonplaten, @LysandreJik
@sgugger, @patil-suraj

@tucan9389
Copy link
Contributor Author

Hi, @sgugger and @patrickvonplaten again.
Like the #13290 PR that I made before, I made QA for GPT-J class and made this PR for that.
If you have time, I'd appreciate your review and feedback on it.

@LysandreJik
Copy link
Member

This seems good to me - @patil-suraj, do you mind taking a look at this?

sgugger
sgugger approved these changes Nov 24, 2021
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this new model!

@patrickvonplaten
Copy link
Contributor

Looks good to me as well! @patil-suraj - could you also take a quick look? :-)

patil-suraj
patil-suraj approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this model!

@sgugger sgugger merged commit 0f3f045 into huggingface:master Dec 6, 2021
@sgugger
Copy link
Collaborator

sgugger commented Dec 6, 2021

Thanks again for your PR!

Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 27, 2022
@tucan9389 @patil-suraj
Add GPTJForQuestionAnswering (huggingface#14503)
e8fad43 
* Add GPTJForQuestionAnswering

* Reformat for GPTJForQuestionAnswering

* Fix isort error

* make style for GPTJForQA

* Add _keys_to_ignore_on_load_missing

* Change the sequence of qa and classification

Co-authored-by: Suraj Patil <surajp815@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickvonplaten patrickvonplaten patrickvonplaten approved these changes

@patil-suraj patil-suraj patil-suraj approved these changes

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tucan9389 @LysandreJik @patrickvonplaten @sgugger @patil-suraj