Add GPT2ForTokenClassification #13290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tucan9389
changed the title
|
Fixed all test failures and all passed. |
src/transformers/modeling_outputs.py
Outdated
| @@ -449,6 +449,42 @@ class SequenceClassifierOutputWithPast(ModelOutput): | |||
| attentions: Optional[Tuple[torch.FloatTensor]] = None | |||
|
|
|||
|
|
|||
| @dataclass | |||
| class TokenClassifierOutputWithPast(ModelOutput): | |||
There was a problem hiding this comment.
Think we can just reuse TokenClassifierOutput no? Don't think it makes sense to use past for token classification. Would one ever do more than one forward pass for token classification? If it's just one forward pass then I think we could force use_cache=False in GPT2ForTokenClassification.
What do you think @tucan9389 ? :-)
There was a problem hiding this comment.
@patrickvonplaten
Thanks for your comment.
Oh, I agree with that. I'll change to TokenClassifierOutput.
sgugger
approved these changes
Aug 30, 2021
|
@sgugger Thanks for approving. @patrickvonplaten I just fixed some errors that occurred in |
patrickvonplaten
approved these changes
Aug 31, 2021
3 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
GPT2ForTokenClassificationclass for GPT2 upstream and NER downstream taskBefore submitting
Pull Request section?
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@patrickvonplaten, @LysandreJik
@sgugger, @patil-suraj