Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doc img links #14593

Merged
merged 5 commits into from
Dec 2, 2021
Merged

Update doc img links #14593

merged 5 commits into from
Dec 2, 2021

Conversation

mishig25
Copy link
Contributor

@mishig25 mishig25 commented Dec 1, 2021 •
edited
Loading

What does this PR do?

Companion PR for huggingface/doc-builder#34

TLDR: all doc img links (both rst & md) should be in format /imgs/xyz.png

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@mishig25 mishig25 requested a review from sgugger December 1, 2021 22:39
sgugger
sgugger approved these changes Dec 1, 2021
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!
There is one more in performance.md introduced by #14579, make sure to rebase on master and add it :-)

@mishig25 mishig25 merged commit 275402b into huggingface:master Dec 2, 2021
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 27, 2022
Update doc img links (huggingface#14593)
06e3efb 
* Update doc img links

* Rename toctree.yml -> _toctree.yml (huggingface#14594)

* Update doc img links

* Update performance.md img link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mishig25 @sgugger