Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] bf16/tf32 guide #14579

Merged
merged 5 commits into from
Dec 1, 2021
Merged

[doc] bf16/tf32 guide #14579

merged 5 commits into from
Dec 1, 2021

Conversation

stas00
Copy link
Contributor

@stas00 stas00 commented Dec 1, 2021

This PR adds performance-specific docs as a follow up to #13207

  • adds the missing --fp16_full_eval
  • adds --bf16 and --bf16_full_eval
  • adds discussion of tf32

This is the first pass, surely will add more down the road.

@sgugger

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one fix is needed to go with the new doc front (image links are now different).

docs/source/performance.md Outdated Show resolved Hide resolved
stas00 and others added 2 commits December 1, 2021 13:56
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
@stas00 stas00 merged commit fbe278c into huggingface:master Dec 1, 2021
@stas00 stas00 deleted the doc-bf16-tf32 branch December 1, 2021 22:19
Copy link
Contributor

@manuelciosici manuelciosici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stas00 Looks good. Minor things. I am sorry for adding everything as comments, the GitHub "Insert a suggestion" button doesn't appear for me.

docs/source/performance.md Show resolved Hide resolved
docs/source/performance.md Show resolved Hide resolved
docs/source/performance.md Show resolved Hide resolved
@stas00
Copy link
Contributor Author

stas00 commented Dec 2, 2021

Thanks a lot for the proofreading and the corrections, @manuelciosici

You couldn't make suggestions since the PR was merged already.

I applied your corrections to this ongoing PR #14580 that collects small fixes.

I even figured out how to make the right attribution to your suggestions ;)

git commit --author "Manuel R. Ciosici <manuelrciosici@gmail.com>" -ma "corrections"

Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 27, 2022
* [doc] bf16/tf32 guide

* expand

* expand

* Update docs/source/performance.md

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants