Add missing type hints for all flavors of LayoutLMv2 PyTorch models. #16089
Conversation
|
This also looks good, but same comment about the return types! |
|
The documentation is not available anymore as the PR was closed or merged. |
Yes I fixed return types + I added all type hints for |
|
Hi, I'm seeing some tests failing on this one - I think you might have deleted a couple of arguments while adding the annotations! |
| head_mask=None, | ||
| inputs_embeds=None, | ||
| encoder_hidden_states=None, | ||
| encoder_attention_mask=None, |
There was a problem hiding this comment.
These arguments encoder_hidden_states and encoder_attention_masks are not used.
Should I fix tests too or it's out of the scope of this PR ?
There was a problem hiding this comment.
I think it's out of scope of this PR, but good catch nonetheless! I'm not sure why the arguments are there if they're not used, but you can raise an issue after this PR is merged if you like.
What does this PR do?
I added type hints for all
LayoutLMv2PyTorch classes as described in #16059 .@Rocketknight1