Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZeRO] Fixes issue with embedding resize #16093

Merged
merged 2 commits into from
Mar 11, 2022
Merged

[ZeRO] Fixes issue with embedding resize #16093

merged 2 commits into from
Mar 11, 2022

Conversation

jeffra
Copy link
Contributor

@jeffra jeffra commented Mar 11, 2022

What does this PR do?

Fixes #16008.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@stas00

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 11, 2022

The documentation is not available anymore as the PR was closed or merged.

Co-authored-by: Stas Bekman <stas00@users.noreply.github.com>
Copy link
Contributor

@stas00 stas00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix, Jeff.

It probably means this path isn't being tested on our side.

And I also run all the tests locally - all pass.

@stas00 stas00 merged commit c1f209d into huggingface:master Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resize_token_embeddings() failed with GPT-J, after sync to the latest DeepSpeed 0.6.1
3 participants