Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unpack_input decorator to ViT model #16102

Merged
merged 1 commit into from
Mar 12, 2022
Merged

Add unpack_input decorator to ViT model #16102

merged 1 commit into from
Mar 12, 2022

Conversation

johnnv1
Copy link
Contributor

@johnnv1 johnnv1 commented Mar 12, 2022

What does this PR do?

I added the unpack_input decorator for the ViT model as describe in #16051

@gante

Maybe can also delete the **kwargs from call parameters? (tests seems unaffected)

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 12, 2022

The documentation is not available anymore as the PR was closed or merged.

@gante gante self-requested a review March 12, 2022 14:13
Copy link
Member

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you so much for the contribution 👍

Can you confirm that you've run RUN_SLOW=1 py.test -vv tests/[model_name]/test_modeling_tf_[model_name].py? Will merge after your confirmation :)

@gante
Copy link
Member

gante commented Mar 12, 2022

Maybe can also delete the **kwargs from call parameters? (tests seems unaffected)

That's a good point. Actually, I think this will be true for all models after this change. Do you mind if I add it to my backlog, to confirm after this sprint? If we were to change this, I would have to bring in other Hugging Face members in (changing the signature of a public method is sensitive).

@debtriche
Copy link

debtriche commented Mar 12, 2022 via email

@gante
Copy link
Member

gante commented Mar 12, 2022

Hi @debtriche 👋 GitHub doesn't send random emails, if you are receiving unwanted emails please check your subscription and emailing settings :)

@johnnv1
Copy link
Contributor Author

johnnv1 commented Mar 12, 2022

Fantastic, thank you so much for the contribution +1

Can you confirm that you've run RUN_SLOW=1 py.test -vv tests/[model_name]/test_modeling_tf_[model_name].py? Will merge after your confirmation :)

Yes, i run, but two test are skipped, all others pass

@gante gante merged commit 8416206 into huggingface:master Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants