Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dcoker images runtime -> devel #16141

Merged
merged 2 commits into from
Mar 14, 2022
Merged

Dcoker images runtime -> devel #16141

merged 2 commits into from
Mar 14, 2022

Conversation

LysandreJik
Copy link
Member

Updates the base image for the docker images used for testing to use the devel version of the original docker images instead of the runtime version, as it's the version necessary for some TF utilities to run.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you, @LysandreJik , we would have many fewer CI failures now!

(I don't know well yet the change about deepspeed in this PR, but I trust you :-) here.)

@ydshieh
Copy link
Collaborator

ydshieh commented Mar 14, 2022

Let me just add a failing example before this PR:
(just for the record)

tests/bart/test_modeling_tf_bart.py::TFBartModelTest::test_xla_mode
(line 54)  tensorflow.python.framework.errors_impl.InternalError: libdevice not found at ./libdevice.10.bc [Op:__inference_run_in_graph_mode_1125293]

@LysandreJik LysandreJik merged commit c1000e7 into master Mar 14, 2022
@LysandreJik LysandreJik deleted the docker-images-devel branch March 14, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants